Skip to content

fix: Formatting toolbar not hiding while dragging blocks #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewlipski merged 2 commits into from
Jan 22, 2024
Merged

fix: Formatting toolbar not hiding while dragging blocks #529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c237cd
Fixed formatting toolbar not hiding while dragging blocks
matthewlipski Jan 18, 2024
332e591
Small fix
matthewlipski Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export class FormattingToolbarView {

pmView.dom.addEventListener("mousedown", this.viewMousedownHandler);
pmView.dom.addEventListener("mouseup", this.viewMouseupHandler);
pmView.dom.addEventListener("dragstart", this.dragstartHandler);
pmView.dom.addEventListener("dragstart", this.dragHandler);
pmView.dom.addEventListener("dragover", this.dragHandler);
Comment thread
matthewlipski marked this conversation as resolved.

pmView.dom.addEventListener("focus", this.focusHandler);
pmView.dom.addEventListener("blur", this.blurHandler);
Expand All @@ -70,7 +71,7 @@ export class FormattingToolbarView {
};

// For dragging the whole editor.
dragstartHandler = () => {
dragHandler = () => {
if (this.formattingToolbarState?.show) {
this.formattingToolbarState.show = false;
this.updateFormattingToolbar();
Expand Down Expand Up @@ -177,7 +178,8 @@ export class FormattingToolbarView {
destroy() {
this.pmView.dom.removeEventListener("mousedown", this.viewMousedownHandler);
this.pmView.dom.removeEventListener("mouseup", this.viewMouseupHandler);
this.pmView.dom.removeEventListener("dragstart", this.dragstartHandler);
this.pmView.dom.removeEventListener("dragstart", this.dragHandler);
this.pmView.dom.removeEventListener("dragover", this.dragHandler);

this.pmView.dom.removeEventListener("focus", this.focusHandler);
this.pmView.dom.removeEventListener("blur", this.blurHandler);
Expand Down