fix: Mantine setting global styles - #525
Closed
matthewlipski wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Collaborator
|
closing, main issue is fixed by upgrading mantine (#535) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the Mantine update from 0.11, the way in which Mantine component styling is now different. Mantine now sets styles in CSS, some of which are set globally. This can cause issues by overwriting existing styles, when in reality they should be scoped to only elements within the editor.
This PR unsets global styles set by Mantine and moves them inside the
.bn-containerelement (excluding setting CSS variables). Unfortunately, for Mantine styling to work at all, you need to import@mantine/core/styles/global.css, which includes said global styles. This means that AFAIK, there is no way to skip importing them, and the best we can do is to unset them. This feels really hacky, so any suggestions for a nicer fix are welcome.Closes #523