Improve error handling for initialContent in BlockNoteEditor - #349
Closed
marwan37 wants to merge 1 commit into
Closed
Improve error handling for initialContent in BlockNoteEditor#349marwan37 wants to merge 1 commit into
marwan37 wants to merge 1 commit into
Conversation
|
@marwan37 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
58 tasks
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
BlockNoteEditordoes not provide clear error messages when invalidinitialContentis passed. This PR improves the error handling by adding more descriptive error messages and checks for required keys in block objects.fixes: #342
Changes
BlockNoteEditor.tsfor invalidinitialContent.defaultInitialContent;initialContentdefaults to this if checks fail.initialContentfrom const to let for reassignment (further guidance is appreciated if undesirable).Testing
initialContent = "abc":initialContent = ["abc"]:[{ someKey: "abc", id: "123123" }]: