Repository navigation
Conversation
An ACP client with `subagent.enabled` is registered as a tool
(`acp__<client>__prompt`), but no Agent manifest ever listed that tool name, and
`resolve_tool_manifest_policy` only exposes tools contained in the manifest
allowlist. An ACP subagent the user explicitly enabled therefore stayed
unreachable for the model, while the settings page kept showing it as
configured and running.
Append registered ACP tools alongside the existing dynamic MCP merge, and keep
ACP tools out of remote-workspace sessions, where they cannot run because
`AcpAgentTool::call_impl` never forwards a remote connection id.
`get_agent_tool_policy` is the only place that builds an agent's tool allowlist
(execution engine, tool catalog, MCP catalog, plugin host and skill snapshots
all consume it), so merging there covers every consumer. The merge order is
extracted into `merge_dynamic_mode_tools` so a unit test fails if the ACP
merge is ever dropped again.
The tool-name prefixes stay local string constants: the canonical
`openbitfun_agent_tools::{ACP_TOOL_PREFIX, MCP_TOOL_PREFIX}` sit behind that
crate's `acp-bridge` / `mcp-bridge` features, which `openbitfun-core` does not
enable, so this module also compiles under `agent-runtime` alone.
TunaTung
force-pushed
the
fix/acp-subagent-tool-exposure
branch
from
September 17, 2026 12:48
f16bf78 to
ea6ec85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR opened only to run this repository's own CI on the exact commit submitted to GCWing#3086, because the submitting machine has no Rust toolchain. Identical tree; will be closed once the checks report.