Repository navigation
feat(composer): one collapsible question card for both deliveries - #596
Merged
Merged
Conversation
The agent question card now keeps a one-line strip and folds its answer area away, so the conversation behind it can be read while deciding, and the question with its options scrolls inside a share of the window so a long question no longer pushes the composer off a phone screen. Blocking questions arrive open and cannot be hidden; non-blocking ones arrive closed and can be hidden as before.
Tryanks
force-pushed
the
feat/question-card-collapsible
branch
from
October 6, 2026 07:35
04a0770 to
3f30370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A long agent question (Claude
AskUserQuestion, CodexrequestUserInput) used to render its whole text unbounded above the composer; on a phone it filled the screen and pushed the input off it. Both deliveries now share one card: a one-line strip that stays, and an answer area that folds away and scrolls inside a share of the window.Behaviour that stays: single-select auto-advances and submits, multi-select finishes with Done, digits 1-9 in the empty composer answer a blocking question, Enter in the composer submits the custom answer while blocked.
Evidence
Before: the screenshot in the request — a blocking question's text filling a phone screen, composer off-screen.
After: desktop app at 700×620 with a ~1200-char
AskUserQuestionfrom Claude Code: card capped at 248 px, question scrolls inside it, composer visible; strip click collapses it to one line showingDesign We are considering the overall design direc…, click again restores it.Tests (
cargo nextest run -p tcode-ui user_input): 4 passed.async_question_strip_controlskept: strip buttons act once without reaching the strip underneath; async arrives closed, can be hidden, has a way back. Selectors renamedui-async-*→ui-*since they are no longer async-only.blocking_question_collapses_but_staysadded: blocking arrives open, folds, never shows ✕, prev/next reopen it.Checks run:
cargo fmt --all --check,cargo clippy -p tcode-ui --all-targets --locked -- -D warnings,cargo nextest run -p tcode-ui. Not run: full-workspace clippy (onlycrates/uichanged), dark theme, a real phone or thephoneexample (it needs a paired host; the compact path differs only in touch sizes).Merge Danger
Door: two-way
One component, no protocol or state change outside the composer; revert is a single commit.
Blast Radius: composer
Visual change to every agent question on every client. Async questions lose the chip layout and gain option descriptions and the same rows as blocking ones.