Repository navigation
fix(composer): send commands and skills the way the harness expands them - #593
Merged
Merged
Conversation
The `/` menu now opens only at the start of the message and never for a path, and a `/` or `$` token that matches nothing opens no menu, so Enter submits it instead of being swallowed. A leading `$skill` is sent as `/skill` when the provider also lists it as a command (Claude), the only form Claude Code expands; Codex mentions stay `$skill`. The Ultrathink keyword trails a slash command instead of displacing it from byte 0. Codex `~/.codex/prompts` entries are no longer offered: the app-server neither lists nor expands them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What the composer sends, before and after, per provider:
Why: Claude Code expands a command or skill only when
/nameis the first byte of the user text; anything else reaches the model as plain text and the model then calls the Skill tool itself. Codex's app-server expands$namein plain text itself and has no API for custom prompts (deprecated upstream).Evidence
Before: typing
/Users/me/notes.mdopened an empty "No matching command." menu and Enter did nothing;$pongskillto Claude andUltrathink:\n/pongcmdboth producedTOOL-USE: Skill(model-driven), and/pongprompton Codex made the modelcatthe prompt file.After: same stream-json messages the runtime now produces, driven straight into the CLIs:
New tests, all passing with the rest of the workspace (889 run, 0 failed):
Merge Danger
Door: two-way
Pure client-side behaviour; reverting restores the old trigger rules and wire text.
Blast Radius: composer
Three visible changes for existing users:
/on a second line no longer opens the menu; the "No matching command / No skills found" empty states are gone (an unmatched token is just text); Codex users lose~/.codex/promptsentries from the/menu. A$skillsent to Claude now arrives as/skill, so the bubble shows$skillwhile the CLI runs the command.