Repository navigation
fix: open the composer's /, @ and $ menus on the phone - #582
Merged
Merged
Conversation
The compact layout cleared the active trigger on every input change, so typing / @ or $ on a phone never opened a menu, and /later was sent to the agent as text instead of being scheduled. Both guards came with the first mobile client; every data path behind the menus is protocol-backed, so the phone uses the same trigger owner as the desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typing
/,@or$in the composer on a phone now opens the same trigger menu as on the desktop, and/laterschedules the turn instead of being sent to the agent as literal text.Two guards from the first mobile client (#329) were responsible. Both are removed and nothing is added.
compactisis_mobile && compact_for(width), so desktop builds were never affected. The menus' data was already protocol-backed (provider commands,Query::ListActiveWorkspace,Command::ScheduleTurn), so a remote phone needs nothing else.Evidence
/showed nothing and/later …went to the agent as text.After:
cargo run -p tcode-ui --example phoneagainst a throwaway headless host:/lists the built-in commands,/planswitches mode,@lists and inserts remote files.the_phone_composer_opens_the_same_trigger_menusbuilds the composer as the phone does at 393×852, types/and@through the window input handler, draws, and asserts the first menu row is laid out. It fails with the guard restored. No test owned this contract before.Merge Danger
Door: two-way
Two lines of guard removed; trivially revertible.
Blast Radius: phone-composer
Not exercised on a real device: iOS and Android soft keyboards (including CJK IME composition of
/), menu placement with the keyboard up, touch taps on menu rows, and provider-native commands or$skills on the phone. On mobile Return inserts a newline, so a row is accepted by tap.