Skip to content

docs: what to do when a test fails - #570

Merged
Tryanks merged 2 commits into
mainfrom
docs/failing-tests
Oct 1, 2026
Merged

Tryanks merged 2 commits into
mainfrom
docs/failing-tests

Conversation

@Tryanks

@Tryanks Tryanks commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Changed behaviour

Generalizes the rule the gpui-fast switch (#555) established for dependency problems to any failing test.

  • Principle 8 gains: a test is truth only for a contract real use needs; a failing test is first a question about the test (its contract, and whether it drives the code as the app does) and only then a verdict on the code; such a test is deleted with the code that existed only for it; a test is never edited into passing.
  • Process → When a test fails: a four-step order — reproduce as the app would (driver faults are fixed in the driver, which is what build(deps): run on gpui-fast instead of the gpui-pre snapshots #555 was), judge the assertion against a real contract and delete test plus test-only code when there is none, only then treat the code as broken, and say in the PR which it was with evidence. Applies to intermittent failures too; "make it pass" (loosen, rewrite to the new output, retry, add a seam) is named as not a step.
  • Cross-references from "Tests earn their maintenance" and the AGENTS.md pointer.

Documentation only. Principle text is maintainer-authored: left open for the maintainer's review of the wording.

A failing test is first a question about the test, whether it states a
contract real use needs and drives the code the way the app does, and
only then a verdict on the code. Process gets the decision order; a
test is never edited into passing.
@Tryanks
Tryanks merged commit f143bda into main Oct 1, 2026
7 checks passed
@Tryanks
Tryanks deleted the docs/failing-tests branch October 1, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant