build(deps): use the published block crate - #559
Merged
Merged
Conversation
The vendored block 0.1.6 patched an upstream declaration Tcode never uses: block reaches the build only through GPUI's Cocoa, Core Video and Metal dependencies. The published crate builds with warnings denied; its uninhabited extern static shows only as a future-incompatibility report, which Tcode carries until those dependencies move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
vendor/blockand the[patch.crates-io]entry that swapped it in.History
The vendored copy came in with #459 ("Restore paired sessions and Preview after Wi-Fi changes"), unrelated to that PR's subject.
block0.1.6 declares_NSConcreteStackBlockwith an uninhabited type, which rustc'suninhabited_staticlint says a future Rust will reject. The copy replaced that declaration, spelled outextern "C", and restored the crate's test utilities.Why it goes
block. It reaches the build only transitively, through GPUI's Apple dependencies:cocoa,cocoa-foundation, andcore-graphics2viacore-video.-D warnings.Cargo.locknow takesblock0.1.6 from crates.io; its checksum matches the one recorded in the removedPATCH.md.Checks run (macOS arm64, rustc 1.98.1)
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo machete: pass.RUSTFLAGS='-D warnings' cargo check -p tcode-ios --target aarch64-apple-ios-sim --locked: pass. The future-incompatibility report is printed, not an error.cargo nextest run --workspace --locked: 975 passed, 2 failed. The two failures weretcode-traversetransport tests that timed out after 20s; they don't depend onblock, and all 8 transport tests pass on rerun.🤖 Generated with Claude Code