docs(contributing): keep upstream problems inside Tcode - #558
Merged
Merged
Conversation
Principle 9 read as permission to feed fixes back to an upstream. It now allows investigating and locally patching a dependency to confirm a cause, routes findings to the maintainer or this repository, and leaves any action on the upstream to an explicit maintainer request. Process gains the order for working a problem that may be a dependency's, and AGENTS.md points there for that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Principle 9 said to "feed findings back" to an upstream and assumed Tcode proposes fixes there ("when upstream declines a fix"). In #555 that wording led an agent to write a gpui-fast patch and recommend submitting it. The maintainer's rule is the opposite, and this PR puts it in the Principles.
Changes
This PR changes the Principles, the maintainer-authored section, so it needs the maintainer's own review before merging.
Open point, not changed here:
vendor/blockis a patched copy of a dependency swapped in through[patch.crates-io], which sits uneasily with "never fork a dependency".🤖 Generated with Claude Code