Skip to content

docs(contributing): keep upstream problems inside Tcode - #558

Merged
Tryanks merged 1 commit into
mainfrom
docs/upstream-policy
Sep 30, 2026
Merged

Tryanks merged 1 commit into
mainfrom
docs/upstream-policy

Conversation

@Tryanks

@Tryanks Tryanks commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Principle 9 said to "feed findings back" to an upstream and assumed Tcode proposes fixes there ("when upstream declines a fix"). In #555 that wording led an agent to write a gpui-fast patch and recommend submitting it. The maintainer's rule is the opposite, and this PR puts it in the Principles.

Changes

  • Principle 9. Investigating an upstream problem is allowed: reading its source, building it, and patching a local copy to confirm a cause. The problem is judged by its effect on Tcode's real use. Findings go to the maintainer or to an issue in this repository. Diagnostic patches stay local and are discarded, and Tcode carries the bug until upstream changes on its own. Any action on an upstream (issue, PR, comment, patch) is never recommended or offered; it happens only when the maintainer explicitly asks, with the maintainer taking part throughout.
  • Process: "Problems that may be a dependency's". The order to work such a problem:
    1. Localize the cause, treating a test as valid only once it drives the dependency the way the running app does.
    2. Weigh the impact on real use.
    3. Confirm the cause on a local copy.
    4. Report to the maintainer or in this repository.
    5. Carry the problem inside Tcode.
  • AGENTS.md. The pointer to CONTRIBUTING now also names this case.

This PR changes the Principles, the maintainer-authored section, so it needs the maintainer's own review before merging.

Open point, not changed here: vendor/block is a patched copy of a dependency swapped in through [patch.crates-io], which sits uneasily with "never fork a dependency".

🤖 Generated with Claude Code

Principle 9 read as permission to feed fixes back to an upstream. It now
allows investigating and locally patching a dependency to confirm a
cause, routes findings to the maintainer or this repository, and leaves
any action on the upstream to an explicit maintainer request. Process
gains the order for working a problem that may be a dependency's, and
AGENTS.md points there for that case.
@Tryanks
Tryanks merged commit 4075613 into main Sep 30, 2026
7 checks passed
@Tryanks
Tryanks deleted the docs/upstream-policy branch September 30, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant