fix(ui): say that archiving a thread can be undone - #551
Merged
Merged
Conversation
The archive confirmation claimed archiving cannot be undone and styled the action as destructive, but archived threads are restored from Settings → Archived Threads. Describe what archiving does instead, and drop the danger style from both the single and the archive-all confirmation. Closes #519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #519
Changed behaviour
The sidebar's archive confirmation said archiving "cannot be undone" and styled the action as destructive. Archiving can be undone: it stops the thread's agent, and the thread can be restored from Settings → Archived Threads.
sidebar.archive_description(en, zh-CN) now says what archiving does and where to restore the thread.Danger. Delete and remove-project stayDanger.No code paths change beyond the button variant. Once archive gets an undo toast (#529), this confirmation may not be needed at all.
Test
None added. This is a string and a style change, and the locale parity test already checks that both locales have the key.
Checks run locally (macOS)
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo nextest run --workspace --locked: 947 passed, 5 skippedNot run locally: iOS/Android/Web checks and
cargo machete(CI covers them).Visual check: I ran this branch's debug build in a macOS 26.4 tart VM (1024×768, light theme) and opened the sidebar archive confirmation on an imported thread. It shows the new text, and Archive is the primary (blue) button. Not checked: dark theme, zh-CN, and the archive-all dialog.