Bump gpui-kit to 0.6.6 and gpui-pre to 0.3.6 - #544
Merged
Merged
Conversation
gpui-base, gpui-kit-assets, gpui-component-macros and gpui-wry 0.6.4 -> 0.6.6, and every gpui-pre crate 0.3.5 -> 0.3.6, including the workspace-excluded iOS and Android backends. gpui-base 0.6.6 pins gpui-pre =0.3.6; its own sources are unchanged from 0.6.4. Only the gpui entries in Cargo.lock were updated; gpui-pre-media is gone and objc2-core-audio/-audio-types/-media come in with gpui-pre-macos moving screen capture to objc2 bindings. No source changes are needed: PlatformAtlas taking its key by value and the new PlatformTextSystem::set_missing_glyph_sink (default no-op) do not touch code the mobile backends implement or call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the tree to gpui-kit 0.6.6 / gpui-pre 0.3.6 (zed@d89e9c2 → zed@bcf6582). No Tcode source changes.
Dependencies
gpui-base,gpui-kit-assets,gpui-component-macros,gpui-wry0.6.4 → 0.6.6; everygpui-pre-*crate 0.3.5 → 0.3.6, including the excludedcrates/platform/gpui-iosandgpui-android. gpui-base 0.6.6 pinsgpui-pre =0.3.6; its sources (and those of the other three gpui-kit crates) are byte-identical to 0.6.4.Cargo.lockchanged.gpui-pre-mediais removed;objc2-core-audio,objc2-core-audio-types,objc2-core-mediaarrive with gpui-pre-macos's screen capture moving to objc2.Upstream changes that reach Tcode without code changes
traffic_light_positionafter leaving fullscreen (previously they could keep their fullscreen frames).ActiveAlwaystracking area, so hover states update while the app is inactive.WindowBounds::centeredcenters on the display's visible bounds and clamps the size to them, so the 1200×800 default no longer sits under the menu bar/Dock or overflows small screens.debug_boundsis also recorded for elements inside cached views.New API, not adopted
App::on_missing_glyphs(fallback-exhausted grapheme reports). gpui-base does not use it. Adopting it would needAndroidTextSystemto forwardset_missing_glyph_sinkafter its Canvas emoji fallback (as gpui-pre-web does), and the iOS text system to implement it.ShapedLine::cursor()/ShapedLineCursor,paint_with_underline_handler,Window::paint_underline_with_exclusions.Checks run (macOS arm64)
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warningscargo nextest run --workspace --locked: 944 passed, 5 skippedRUSTFLAGS='-D warnings':cargo check -p tcode-ios --target aarch64-apple-ios-sim,cargo ndk -t arm64-v8a check -p tcode-android,cargo check -p tcode-web --target wasm32-unknown-unknowncargo-machete: cleanNot run locally: Windows and Linux builds (left to CI); the app was not launched.