fix(ui): keep a way back to a hidden async question - #543
Merged
Merged
Conversation
Hiding a non-blocking question is local to the client: the question stays open on the host and the sidebar keeps showing it as awaiting an answer, but the composer left no way to reopen it. A hidden question now leaves a small entry above the composer that reopens it expanded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed behaviour
Hiding a non-blocking (Codex
request_user_input_async) question only hides it on this client. It sends nothing to the host or the agent, so the question stays open and the sidebar correctly keeps showing Needs your answer. The composer, however, left no way to reopen it. The user was pointed at a question they could not reach until they switched threads or the agent asked again.A hidden question now leaves a small ghost button above the composer (info icon + "Question from the agent", tooltip "Answer") that reopens the question expanded. It disappears with the question when the question is answered or the turn ends. It reuses existing strings, so there are no locale changes.
The dismissed-request filter moves from
Composer::renderintorender_async_question, the only place that can dismiss. Blocking questions are unaffected.Test
async_question_strip_controls(renamed fromasync_question_strip_buttons_toggle_and_page) now continues past the toggle/paging clicks. Clicking hide removes the strip, and clicking the reveal entry brings the question back expanded. Without this change, the reveal entry does not exist and the test fails at that click.Checks run locally (macOS)
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo nextest run -p tcode-ui --locked: 314 passedNot done: a visual check in the running app, which needs a live Codex async question.