feat(ui): give non-blocking questions their own collapsed style - #538
Merged
Merged
Conversation
A non-blocking question used the blocking question card, which reads as "the agent is waiting on you". It now follows Codex's own clients: it arrives as a one-line strip above the composer (icon, label, question, expand and hide) that never takes focus. Opening it shows a light inline area with the options as chips, a custom answer field and the "agent keeps working" hint. Blocking questions keep the full card unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Non-blocking questions from Codex
request_user_input_async(#536) used the blocking question card. That card reads as "the agent is waiting on you", which is wrong for a question the agent works past.The Codex TUI shows these questions collapsed on arrival, as a one-line "? 1 question" summary that never takes focus, and the user opens them to answer. Tcode now does the same:
requestUserInputkeep the full card unchanged. The non-blocking-only header, hint and hide button are removed from it.New strings for expanding and collapsing are added in English and Chinese.
Checks run
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo nextest run --workspace --locked: all pass locally on macOS.