Skip to content

feat(codex): surface non-blocking asks from request_user_input_async #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tryanks merged 2 commits into from
Sep 24, 2026
Merged

feat(codex): surface non-blocking asks from request_user_input_async #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b97136
feat(codex): surface non-blocking asks from request_user_input_async
Tryanks Sep 24, 2026
a7b415d
fix(codex): record async asks as the tool call, not assistant text
Tryanks Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/agent/examples/probe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ async fn run_probe(
AgentEvent::UserInputRequested {
request_id,
questions,
..
} => {
let answers = questions
.iter()
Expand Down
5 changes: 4 additions & 1 deletion crates/agent/src/claude.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ use crate::{
InteractionMode, ItemContent, ItemStatus, LaunchEnv, ModelSpec, OptionDescriptor,
OptionSelection, PlanStep, PlanStepStatus, ProviderCommand, ProviderCommandKind, ProviderKind,
ResumeCursor, RewindMode, SessionCommand, SessionHandle, SessionOptions, ThreadItem,
TokenUsage, TurnStatus, UserInputOption, UserInputQuestion, selection_bool, selection_str,
TokenUsage, TurnStatus, UserInputDelivery, UserInputOption, UserInputQuestion, selection_bool,
selection_str,
};

/// Denial returned to `ExitPlanMode` after the client captures the plan.
Expand Down Expand Up @@ -2715,6 +2716,7 @@ impl Mapper {
return vec![AgentEvent::UserInputRequested {
request_id,
questions,
delivery: UserInputDelivery::Blocking,
}];
}

Expand Down Expand Up @@ -4984,6 +4986,7 @@ mod tests {
AgentEvent::UserInputRequested {
request_id,
questions,
..
} => {
assert_eq!(request_id, "ctrl-9");
assert_eq!(questions.len(), 2);
Expand Down
Loading