fix(orchestrate): clarify model and endpoint profile parameters - #512
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
profile=gpt-6-solto dispatch failed while the error advertisedenabled profiles: gpt-6-sol. That list actually contained model names:profileselects a provider endpoint configuration. The failure occurred before effort validation, so retrying without both profile and effort incorrectly suggested that high effort was unsupported.Clarify model and endpoint fields in the dispatch/collaborate schemas and injected configuration. Matching errors now label each model/endpoint combination, tell callers to omit profile for built-in endpoints, and explain that effort has not yet been validated. Endpoint selection and effort validation remain owned by the existing resolver.
The regression test reproduces all three rejected parameter combinations and verifies that model-only dispatch works with both default effort and explicit high effort. Its diagnostic assertions failed before the fix and pass afterward; existing named-endpoint coverage remains in place.
Validation on macOS:
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --lockedcargo-machete .(the localcargo macheteinvocation misrouted its subcommand as a directory)No live provider calls were needed for the resolver reproduction. Other desktop platforms and iOS/Android/Web targets are covered by CI before merge.