Move connecting to the Machines page and pair in one step - #511
Merged
Merged
Conversation
Settings → Other devices mixed two things: this machine's hosting configuration and the act of connecting. It is now Settings → Remote and only configures: whether the endpoint runs and accepts new devices, the machine name, Traverse, and the paired devices. The Machines page in the sidebar is where connections are made in both directions: it shows this machine's invitation (QR, countdown, copy link, new invitation) while hosting accepts devices, explains why not and links to the settings otherwise, and lists the saved machines with adding by scan or pasted link. Pairing is one step. A scanned invitation, or a pasted link that parses, is sent at once and the page shows "Connecting to ‹name›…"; the confirmation page and the "Connect to ‹name›" button are gone, and the bottom button only retries after a failure. The sidebar's Machines row shows the machine name and status light only while connected to a remote machine. The Chinese locale returns to 主机 for Machine, which the rest of the app already used. README, docs/remote.md, the traverse-server README and the headless help text follow the new names and flow; the claim that a paired native device can mint an invitation for a headless machine was never true and now reads as browser-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Settings → Other devices mixed this machine's hosting configuration with the act of connecting, and pairing took three screens: the scanned link landed in a text field, a blank confirmation page showed the machine name, and a second button finally connected. The Chinese locale had also drifted from 主机 to 机器 in a WIP commit.
What
docs/remote.md, traverse-server README and headless help text follow the new names and flow.Verified
cargo fmt --check, workspaceclippy -D warnings, all tcode-ui and headless tests,--no-default-featuresbuild; desktop Machines/Settings pages and the phone layout checked by screenshot.