ui: timeline rows carry an edge padding that scrolls with the content - #505
Merged
Merged
Conversation
…lls with the content The header and composer still clip the list flush; the outer inset is unchanged. Inside the list, the first turn gets 8px above and the last turn 8px below, so a reader resting at either end sees air between the edge turn and the chrome. The padding lives on the rows, not the List element, so the scrollbar, wheel and tail-resume measure the same extent. It moves with the edge rows: a prepended history page takes the top padding along with the reservation (the anchor compensation now works on their sum), and an appended turn takes the bottom padding after the former last row is remeasured. History coverage subtracts the padding as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leading_space()drives the anchor compensation and the scroll-back), and an appended turn moves the bottom padding after the former last row is remeasured. History coverage subtracts the padding too.Test plan
cargo test -p tcode-ui(308 passed)cargo clippy -p tcode-ui --all-targetsclean,cargo fmt --checkclean