Nav subtitle and connection dot describe the link only - #500
Merged
Merged
Conversation
…nk state The compact subtitle showed "Syncing" while the workspace waited for its baseline over an up link, which reads as a relay/tunnel re-handshake. Loading the baseline is what the content skeletons show; the subtitle now names the path and "Connected" whenever the QUIC link is up. `ConnectionState::Syncing` carries the path like `Connected`. The traverse transport publishes Syncing with the path it already knows and republishes it on a path change; entering Syncing from another state is still the only thing that restarts a sync, in HostLink and in the store. `remote.state.syncing` has no user left and is removed from both locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the workspace loads its baseline after connecting, the nav subtitle showed "Syncing", which reads as a dropped relay/tunnel re-handshaking. Syncing is a data-loading state, not a link state.
ConnectionState::Syncing { path }carries the path; the transport publishes it at establishment and on path changes without restarting the sync.remote.state.syncingremoved.Checks: fmt, clippy -D warnings, nextest (925 passed), web and iOS target checks.