Fix Add Agent dialog content overflow - #499
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Add Agent dialog painted its catalog and Custom Agent action below the modal because the panel used its natural height and the catalog reserved a separate 360px viewport. Propagate the dialog body height through the panel and let the catalog scroll in the remaining space. Use the shared dialog height cap instead of subtracting another fixed window allowance, which also keeps the action inside a 360×480 window.
Validation:
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo nextest run --workspace --locked: 914 passed, 6 skipped.cargo-machete .: no unused dependencies (the local Cargo subcommand shim incorrectly treatsmacheteas a directory).