Handle IME edit-panel actions (select all, copy, cut, paste) on Android - #491
Merged
Merged
Conversation
BaseInputConnection.performContextMenuAction is a no-op that returns false, so the select-all / paste / copy / cut buttons on Android keyboards' edit panels never reached the draft. Implement it on GpuiInputConnection against the shared Editable and publish the resulting state like any other IME edit. Clipboard access goes through a small seam so the instrumented test covers paste without touching the system clipboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android, the select-all / paste / copy / cut buttons on the keyboard's edit panel did nothing in the input box. IMEs deliver those buttons through
InputConnection.performContextMenuAction, andBaseInputConnectionleaves that method as a no-op returningfalse.Change
GpuiInputConnectionimplementsperformContextMenuActionforselectAll,copy,cutandpasteagainst the sharedEditable, and publishes the resulting state like any other IME edit. Paste goes throughcommitText, so the key-oriented (non-editable) path still reachesnativeCommitText.Clipboardseam; the activity wires it to the existinggpuiReadClipboard/gpuiWriteClipboard.testImeEditPanelActionsEditTheDraftAndClipboardcovers all four actions with a fake clipboard.Verification
./gradlew :app:compileDebugJavaWithJavac :app:compileDebugAndroidTestJavaWithJavacpasses.