Ignore windows-core and webview2-com minor bumps until lb-wry moves - #478
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #467, which cannot be merged right now.
crates/uipinswebview2-com = "0.38.2"andwindows-core = "0.61"to the versionslb-wry 0.53.3(the latest, pulled in throughgpui-wry) resolves: lb-wry requireswebview2-com ^0.38andwindows-core ^0.61, and both sides must drive the same WebView2 COM types. Bumpingwindows-coreto 0.62 on its own makes the COM types inpreview_panel/proxy.rsandload_error.rsmismatch. Dependabot would otherwise keep reopening the bump every week, so this addsignoreentries for the minor updates ofwindows-coreandwebview2-comwith a comment saying to lift them once lb-wry moves to webview2-com 0.39 / windows-core 0.62.No Rust changes; the CI planner classifies this as a configuration-only change.