Bump hmac, pbkdf2, sha1 and sha2 to the digest 0.11 generation - #475
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #468 and #472.
hmac 0.13andpbkdf2 0.13are built ondigest 0.11, so bumping them alone leavesHmac<Sha256>without a matchingDigest/KeyInitimpl for thesha2 0.10type. This moves the whole RustCrypto set used bycrates/remotetogether:hmac 0.13,pbkdf2 0.13,sha2 0.11and the optionalsha1 0.11.Source changes are limited to the new API surface:
identity.rs:new_from_slicenow comes fromhmac::KeyInit, which is imported alongsideMac.server.rs:digest 0.11output arrays no longer implementLowerHex, so the device cache prefix uses the crate's existingencode_hexhelper (same lowercase hex output).ring,rustlsandfutures-rustlsare untouched. Cargo.lock keepssha2 0.10.9andsha1 0.10.7only for their remaining consumers (lb-wryon non-macOS targets,tungstenite 0.27until #474 lands).The external wire fixture test (
host_proof_matches_the_external_wire_fixture) and the identity/auth tests pass unchanged, so HMAC/PBKDF2 outputs are byte-identical.Local evidence (macOS arm64):
cargo fmt --all --check✅cargo clippy --workspace --all-targets --locked -- -D warnings✅cargo build --workspace --locked✅cargo test --workspace --locked✅cargo check -p tcode-remote --no-default-features --features server/--features client✅cargo machete✅