fix(sidebar): show background status in flat thread rows - #438
Merged
Merged
Conversation
The flat thread list rendered its own status text and dot and only checked `working`, so a thread whose turn had finished but still owned provider background tasks (e.g. a Claude Monitor) showed "Working" instead of "Background". Extract thread_status_label and use it for the badge, the flat second-line text and the flat status dot. Also align the flat shapes with the grouped row: flat child rows show the worktree glyph, and renaming hides dots and the timestamp slot. Document the three row shapes and their deliberate differences in DESIGN.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A thread whose turn had finished but still owned provider background tasks (e.g. a Claude
Monitorwatching CI) showed Working in the flat thread list. The grouped view already showed Background viathread_status_badge; the flat root row rendered its own second-line status text and only checkedworking.Runtime and the Claude adapter are correct (verified by replaying a real Monitor trace:
resultpublishesBackgroundTasksChanged{1}thenTurnCompleted). The fork was UI-only.Fix
thread_status_label(approval → input → background → working) and use it for the badge, the flat second-line text, and the flat status dot.docs/DESIGN.md.Net -4 lines.
cargo test -p tcode-ui --lib sidebarpasses; clippy clean.