Fix ordered-list numbering in markdown rendering - #437
Merged
Merged
Conversation
Lists interrupted by a paragraph or code block are separate CommonMark lists with a non-1 start; the renderer numbered every item from its index and so restarted at 1. Carry the parsed start through the List node into the prefix.
Tryanks
force-pushed
the
fix/markdown-ordered-list-start
branch
from
September 15, 2026 21:16
ba6e419 to
5357142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start; the renderer ignored it and numbered from the item index, so every fragment rendered as1..startfrom rushdown throughBlockNode::Listintolist_item_prefix.Rebased on #436, which carries the CI and sidebar-test fixes this needs to build.
Test plan
cargo test -p tcode-ui(416 passed)cargo clippy -p tcode-ui --all-targetscleankeeps_ordered_list_start,ordered_prefix_honours_list_start