Fix five Clippy warnings - #427
Merged
Merged
Conversation
guivieiras
marked this pull request as ready for review
September 13, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict workspace Clippy reported five warnings in approval/input validation, history-error handling, and terminal selection. Simplify the conditions so the check passes while preserving the same behavior. No lint exceptions or new abstractions are added.
The existing tests cover the affected behavior; no new tests were added for these equivalent expression changes.
Validation passed:
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo build --workspace --lockedcargo test --workspace --lockedcargo machete(0.9.2)RUSTFLAGS='-D warnings'macOS, Windows, and iOS checks are left to CI. Local iOS validation requires Xcode, unavailable on this Linux machine.