Skip to content

Fix flaky session replica consistency test - #426

Merged
Tryanks merged 1 commit into
Tryanks:mainfrom
guivieiras:fix/session-replica-wait
Sep 14, 2026
Merged

Tryanks merged 1 commit into
Tryanks:mainfrom
guivieiras:fix/session-replica-wait

Conversation

@guivieiras

Copy link
Copy Markdown
Contributor

The session replica test can compare old messages before new events arrive because both timelines have the same entry and turn counts. This caused intermittent Linux CI failures.

Wait for the second turn’s completion event before comparing contents. The existing assertion still checks that the replica matches the live timeline. Only the test changes.

Validation:

  • Updated test passed 20 consecutive runs.
  • Workspace formatting, build, tests, and dependency checks passed.
  • Strict workspace Clippy reports five existing warnings in command_validation.rs, store/mod.rs, and terminal_drawer.rs, outside this change.
  • Other platform checks are left to CI; this change is confined to a desktop test.

@guivieiras
guivieiras marked this pull request as ready for review September 13, 2026 20:01
@Tryanks
Tryanks merged commit 80dddcd into Tryanks:main Sep 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants