Fix overlapping Chinese text in command panels - #410
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chinese text in expanded command panels overlapped because each Unicode scalar was placed in a single terminal column. Commands now use grapheme widths, reserve spacer cells for wide characters, and wrap or truncate without splitting a grapheme or moving the ellipsis beyond the four-row limit.
The existing command-panel layout remains the owner.
unicode-segmentationkeeps combining sequences together andunicode-widthprovides their display widths. The Chinese regression failed before the fix (中wasNarrow, expectedWide) and passes afterward. Regression tests cover Chinese cell positions through the shared grid layout, wide-character wrapping, combining sequences, emoji, and truncation. The gallery includes the reported command and the visual contract is updated.Validation before rebasing onto current main:
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo build --workspace --lockedcargo test --workspace --locked: 1115 passed, 5 ignoredcargo macheteRUSTFLAGS='-D warnings'Local Android validation could not run because this machine has no NDK. Final-commit cross-platform validation is provided by this PR's CI; merge waits for all checks.
After rebasing onto current main: formatting and
cargo test -p tcode-ui --lib command_ --lockedpass (11 tests).