Paginate the Archived Threads settings page and add Delete all - #394
Merged
Merged
Conversation
Rendering every archived thread as a row with two buttons froze the page once thousands were archived. Render 50 rows per page with a range caption and Previous/Next, and add a Delete all button that always confirms before permanently deleting every archived thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Settings → Archived Threads rendered every archived thread as a row with two buttons and click listeners. With thousands of archived threads the page froze on open.
What
Skipped a virtual list: the settings page scrolls as a whole, and 50 rows per page is cheap.
Evidence
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings: cleancargo test --workspace --locked --no-fail-fast: all passing, including the newpage_boundsunit test and the locale parity test