Clip overlong model names in the compact model picker - #392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile (compact composer), a long model name overflowed the model-picker trigger and overlapped the traits/effort chip beside it: the trigger had
max_w(160px)but never clipped overflow, and its innerh_flexlackedmin_w_0, so the label's.truncate()had no constrained width to work against.This mirrors the sibling
traits-chiptrigger's pattern —overflow_hidden()on the compact button andmin_w_0().overflow_hidden()on the innerh_flex— so the label truncates inside the 160px cap instead of spilling. Compact-only; the desktop layout is unchanged.