Preserve thread recency when reopening from memory - #391
Conversation
|
Hey @Tryanks! Really nice project! I was hunting for a library to start working on a PoC of an agent wrapper. I then found about GPUI, looked for projects that use it and ended up here. I was getting sick of having no other option than electron 😄 Tcode performs really well, the mobile app is lightweight and smooth. Great job! I have some other changes and fixes that I did on my fork here, over the next few days I'll clean them and Fixes:
Improvements:
Tweaks:
Features:
|
|
Hey @guivieiras , thanks — I really appreciate that! I've gone through those branches, and they all look very helpful. In fact, some of the issues they address are things that have bothered me in day-to-day use as well. I guess I'd just gotten so used to them over time that I stopped noticing them enough to actually fix them. If you're interested, please feel free to open PRs for any of these improvements. I'd be very happy to take a closer look and discuss them further there. Thanks again! |
Opening a thread that is still in memory changes its last activity time and moves it up the thread list. This fix keeps that time unchanged when reopening it, just as when opening a thread from disk.
The fix removes one unnecessary save from the existing code. The updated test checks that the activity time stays unchanged both in memory and on disk. It also keeps the existing checks that reopening the thread doesn’t stop its provider.
Implemented with GPT-6 Astra in Tcode