Fix mobile safe-area themes and keyboard focus - #386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile safe-area bands used the near-white T1 reading surface instead of the T0 window canvas. Use the existing opaque canvas for those bands and synchronize iOS/Android system-bar contrast and native fallback backgrounds with the resolved app theme, including explicit themes opposite to the OS setting. Content insets still have one owner and retain
max(safe area, IME).Software-keyboard devices now wait for a tap before focusing the composer at either width. Navigation dismisses focus, while rotation preserves active editing. Restoring an open terminal no longer steals focus through a deferred callback. This extends the existing window/input capability policy and updates
docs/DESIGN.md.Validation:
(252,253,251)to T0(242,244,247); dark edges match(21,23,28).RUSTFLAGS='-D warnings'; both native packages built successfully.cargo-machete .0.9.2 passed after the localcargo macheteentry point misinterpreted its subcommand as a directory. macOS debug linking reported a large unwind-table warning and dependencyblockreported future incompatibility.git range-diffconfirms the accepted patch is unchanged and formatting passes after rebase. Final-head CI passed all six jobs (Plan CI scope, Dependency hygiene, macOS arm64, Linux x64, Windows x64, and Mobile and web checks) onf9a4e5e4765461f1b57a73851ec3a05493934c59: run 34331985107, attempt 2. Windows initially failed the existingpipelined_request_and_chunk_trailers_never_reach_originproxy test with ConnectionReset (10054); one diagnostic rerun without code changes passed that test and all 11 proxy integration tests. The reset root cause remains unproven; this PR does not claim to fix a network race.Other OEMs, older Android APIs and the complete real-device restored-terminal matrix were not exercised. APKs and local screenshot/probe artifacts are not included in this PR.