Skip to content

fix(web): providers settings no longer imply a project scope - #94

Merged
yordis merged 4 commits into
mainfrom
yordis/fix-providers-scope-sentence
Oct 10, 2026
Merged

yordis merged 4 commits into
mainfrom
yordis/fix-providers-scope-sentence

Conversation

@yordis

@yordis yordis commented Oct 10, 2026 •

Copy link
Copy Markdown
Member
  • The Providers page read "Applying settings for on ", but provider settings are machine-wide. Picking a project there only narrows which machines are listed. Turning a provider off "for a project" silently turned it off everywhere on that machine.
  • The project picker no longer appears on that page, so the sentence only names the machine the change is saved to.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes settings URL scope handling and environment resolution for providers; incorrect behavior could affect where provider config is read or written per machine.

Overview
Providers settings are scoped to environment only, so the UI no longer implies project-level saves that could mislead users (e.g. toggling a provider “for a project” affecting the whole machine).

/settings/providers is classified via SETTINGS_ENVIRONMENT_ONLY_PATHS. The scope sentence becomes “Applying settings on” with only the environment picker—no project menu. The settings route keeps singleEnvironment for those paths and, when scope changes there, preserves project in the URL for other pages while stripping checkout.

selectSingleEnvironmentScope now returns only { machine }, using project/checkout only to infer the environment when machine is missing, including fallbacks when scope is unavailable—so a stale project cannot leave providers without a target. Unit tests cover checkout links, project registration, missing projects, and explicit machine selection.

Reviewed by Cursor Bugbot for commit 2a3a171. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread apps/web/src/components/settings/SettingsScopeSentence.tsx
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 835627c0-b1e5-44f8-a335-8b9bd7aeea73

📥 Commits

Reviewing files that changed from the base of the PR and between 03f179c and 2a3a171.


📒 Files selected for processing (4)
  • apps/web/src/components/settings/SettingsScopeSentence.tsx
  • apps/web/src/components/settings/settingsScope.test.ts
  • apps/web/src/components/settings/settingsScopeAxis.ts
  • apps/web/src/routes/settings.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 000588ef-974d-497a-bbda-aef791141ec1




📥 Commits

Reviewing files that changed from the base of the PR and between bb6fe2d and 03f179c.





📒 Files selected for processing (1)
  • apps/web/src/components/settings/SettingsScopeSentence.tsx




Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.






📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The settings scope sentence now uses only an environment picker on the providers settings path. Other non-device-only paths retain the project and environment pickers.

Changes

Settings scope selection

Layer / File(s) Summary
Environment-only settings scope
apps/web/src/components/settings/SettingsScopeSentence.tsx
Adds /settings/providers to the environment-only paths. On that path, changing the picker selects the chosen machine or clears the scope when no machine is selected. Other paths retain the existing project and environment pickers.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge








Merge Risk: ⚪ Minimal · up to 03f17

The providers page now presents environment-only scope, and provider changes remain targeted to the selected environment. No concrete merge-blocking risk is evident.

Pre-merge checks | Passed 3 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The description explains the problem and the behavior change, but it does not follow the required template. It omits the Problem, Change, Scope and approval, and Verification headings, with no approva… Rewrite the description using all required headings. Add the triaged issue or maintainer approval, or explain why this focused bug fix qualifies without one. Document focused tests or manual checks with observed results. Include before/afte…
✅ Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: provider settings no longer imply project scope.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.




Full details: Description check

Explanation

The description explains the problem and the behavior change, but it does not follow the required template. It omits the Problem, Change, Scope and approval, and Verification headings, with no approval or verification evidence.

Resolution

Rewrite the description using all required headings. Add the triaged issue or maintainer approval, or explain why this focused bug fix qualifies without one. Document focused tests or manual checks with observed results. Include before/after screenshots for the UI change and state anything not checked.








✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR




🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR







  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…page

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread apps/web/src/routes/settings.tsx Outdated
… settings pages

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ee16ce. Configure here.

Comment thread apps/web/src/routes/settings.tsx Outdated
…s machine

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit c8f68d3 into main Oct 10, 2026
3 checks passed
@yordis
yordis deleted the yordis/fix-providers-scope-sentence branch October 10, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant