fix: enable event store OpenTelemetry tracing by default - #56
Conversation
PR SummaryMedium Risk Overview Updates the docs/examples to reflect that Written by Cursor Bugbot for commit acbe0ce. This will update automatically on new commits. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the default behavior of event store tracing in the OpenTelemetry setup configuration. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
433c3b4 to
407acf9
Compare
The event_store option in Commanded.OpenTelemetry.setup/1 was the only tracing module disabled by default, inconsistent with all other modules (aggregate, aggregate_populate, application, event_handler) which default to enabled. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
407acf9 to
acbe0ce
Compare
Summary
event_storeoption inCommanded.OpenTelemetry.setup/1was the only tracing module disabled by default (:disabled), while all other modules (aggregate, aggregate_populate, application, event_handler) default to enabled ([]).[]so all OTEL tracing is enabled consistently when callingsetup/0.Test plan
mix test test/opentelemetry/event_store_test.exs— all 15 tests passmix compile --warnings-as-errors— clean compilation