Skip to content

ci: run editorconfig-checker - #208

Merged
dangreen merged 3 commits into
mainfrom
ci/run-editorconfig-checker
Oct 19, 2026
Merged

dangreen merged 3 commits into
mainfrom
ci/run-editorconfig-checker

Conversation

@dangreen

@dangreen dangreen commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Why

The editorconfig job installs editorconfig-checker but never runs it: the main branch of editorconfig-checker/action-editorconfig-checker only adds the binary to PATH, and the example workflow of the action runs it in a step of its own. The job moved from @v1, a Docker action that ran the check by itself, to @main in 5b67125 without such a step, so it has not checked a file since September 2023.

Run as is, editorconfig-checker v4.0.2 reports 14 errors, all from its indent-size rule, which wants every left-padding to be a multiple of indent_size. They are 13 lines of numbered list items in skills/setup-simple-release-action/SKILL.md and three pages of the docs, which markdown aligns with the text of the item, 3 spaces after 1. , and a comment in website/src/styles/global.css continued under its own text.

What

  • Multi-line CSS comments take the JSDoc layout: /** and */ on lines of their own, with an asterisk at the start of every line between them. The text keeps its column, and every left-padding is even.
  • Numbered list items with nested content are written as 1. followed by two spaces, so the content sits at 4 spaces instead of 3.
  • The step with the action is now named Install editorconfig-checker, and a new Check editorconfig step runs editorconfig-checker.

Notes

  • .editorconfig stays as it is, so every file is still checked against indent_size.
  • The changed markdown parses to the same tree as before, checked with mdast-util-from-markdown and its GFM and MDX extensions.
  • With these changes, editorconfig-checker v4.0.2 finds no errors on main.

@coveralls

coveralls commented Oct 18, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39132605550

Coverage remained the same at 69.769%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1046
Covered Lines: 725
Line Coverage: 69.31%
Relevant Branches: 211
Covered Branches: 152
Branch Coverage: 72.04%
Branches in Coverage %: Yes
Coverage Strength: 10.93 hits per line

💛 - Coveralls

@dangreen
dangreen force-pushed the ci/run-editorconfig-checker branch from 9c706ec to 51744a6 Compare October 18, 2026 13:01
@dangreen dangreen changed the title ci: run editorconfig-checker without the indent-size rule ci: run editorconfig-checker Oct 18, 2026
@dangreen
dangreen force-pushed the ci/run-editorconfig-checker branch from 51744a6 to aa308d0 Compare October 18, 2026 13:40
@dangreen
dangreen merged commit 48b1ed7 into main Oct 19, 2026
7 checks passed
@dangreen
dangreen deleted the ci/run-editorconfig-checker branch October 19, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants