Repository navigation
build: update Node.js to v26 and pnpm to v12 - #403
Merged
Merged
Conversation
Pin Node.js 26.10.0 in `.tool-versions` and make every CI job read it. The unit job also runs on Node.js 22, the floor of `engines`, which stays as it is, and `@types/node` goes back to `^22` to match that floor.
Pin pnpm 12.9.1 and ask CI for pnpm 12. Settings need no migration from pnpm 11. The lockfile records `linkDirectory: false` of the package, which a frozen install of pnpm 12 checks, and pnpm 12 finds it up to date with that alone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 5 5
Lines 131 131
Branches 35 35
=======================================
Hits 129 129
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repository was developed on Node.js 24.17.0 and pnpm 11.9.0, and CI ran on Node.js 24 alone, so nothing checked the floor of
engines.node,>=22. Node.js 26 is the latest release line and becomes an LTS on 2026-10-28, while the package keeps supporting Node.js 22 until its end of life on 2027-04-30.pnpm 12 is the latest release, and its breaking changes leave the repository alone: pnpm 12 recognizes every setting of
pnpm-workspace.yaml, nothing passes--frozen-lockfile false, no dependency comes from git, andengineStrictis off. The one change it asks for is in the lockfile: pnpm 12, like pnpm 11.28, compares thepublishConfig.linkDirectoryof the package with the lockfile, so a frozen install of the old lockfile fails withERR_PNPM_OUTDATED_LOCKFILE. CI onmasterfails that way already, sinceversion: 11brings pnpm 11.28.What
.tool-versionspins Node.js 26.10.0, the latest 26, and pnpm 12.9.1, the version of thelatesttag. Everyactions/setup-nodestep reads Node.js throughnode-version-file, so a bump of the file moves local development and CI together, and everypnpm/action-setupstep asks for pnpm 12.unitjob runs on a matrix of Node.js 22, the floor ofengines, and the version of.tool-versions, and uploads coverage from the latter alone.@types/nodegoes from^24back to^22, the floor, so the types catch an API of a newer Node.js. The lockfile moves it from 24.13.3 to 22.20.5, withundici-typesalong, and re-keys the peer variants that take it.linkDirectory: falseof the package, the way pnpm 12 writes it. pnpm 12 finds it up to date with this line, and a plain install changes nothing.Notes
engines.nodestays>=22, so nothing gets released.@types/node, so it is going to offer^24again.unitcheck now reports asunit (22)andunit (.tool-versions). No branch protection or ruleset requires the old name.minimumReleaseAgehas applied since pnpm 11, so the move to 12 changes nothing about it, andminimumReleaseAgeExcludestays as it is.@types/node22, the unit tests pass on Node.js 26 and 22, the build passes and size-limit measures the same 855 B as on Node.js 24, on pnpm 12pnpm run emitDeclarationstriggers no install before the script, andlint-package-jsonpasses throughpnpm dlxon both versions of pnpm.