Skip to content

NuisanceFacilityEnumeration documentation update #233

Description

@syversenkr

See #132 (pull requested to 'master' branch, instead of 'next', due to discrepancies in current spec vs UML model vs implementation)

See NeTEx part - 1 7.7.14.4.2 Accommodation Facilities - NuisanceFacilityEnumeration:

"animalsAllowed" present in UML and now added to the XSD is missing in NuisanceFacilityType – AllowedValues
"noAnimals" is present in UML and XSD, but not listed in NuisanceFacilityType – AllowedValues
"breastfeedingFriendly" is present in XSD but missing in both UML and NuisanceFacilityType – AllowedValues
And "other" is missing in the XSD, instead implemented as "unknown"

This should be corrected/consolidation.

In this case "other" makes more sense semantically (as not specified equals unknown), but if deprecating "unknown" this enumeration type is no longer backwards compatible.

Have therefore not added this enumeration to the XSD, would still recommend replacing "unknown" with "other".

If not, the UML and NuisanceFacilityType – AllowedValues must be updated to "unknown", or the type should contain both enumeration values.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions