Skip to content

Off state for PowerLED() has been added to styles under LED class. - #10

Open
kendimce wants to merge 2 commits into
TomAFrench:masterfrom
bimec:master
Open

kendimce wants to merge 2 commits into
TomAFrench:masterfrom
bimec:master

Conversation

@kendimce

Copy link
Copy Markdown

Off state has been added as "Off":"none" to LED._styles but needs to be updated for specificly 'Off' state.

@TomAFrench

Copy link
Copy Markdown
Owner

Hi @kendimce, can you give some background for this PR? It's been a while since I wrote this code but from what I remember the _styles dictionary maps the printed output from the kernel module back into the corresponding input commands. To my knowledge the kernel module doesn't have an "Off" state.

@kendimce

Copy link
Copy Markdown
Author

Hi @TomAFrench we recently bought couple of Intel NUC6CAYs and thankfully tried your module. It's working perfectly for RingLED class but for PowerLED it returns 'Key Error' from _styles in _get_state_from_text method as the state is 'Off'. Please see the screenshot below.

Screenshot from 2020-08-12 23-14-40

@TomAFrench

Copy link
Copy Markdown
Owner

Ah awesome. That definitely needs a fix. I have the same NUC as you so I'm not sure why you're running into this while I haven't. I'll see if I can replicate and will merge/push to pypi soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants