Repository navigation
Fix TUI Inbox and Outbox resource selection - #190
Merged
Merged
Conversation
LIghtJUNction
marked this pull request as ready for review
September 30, 2026 08:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 30, 2026
This was referenced Sep 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #82.
Mailbox records contain their own message ID and a separate resource reference. The TUI previously selected the message ID and called discovery.get on it, so opening an Inbox/Outbox entry failed with not_found. Resolve and display resource.id for mailbox pages, reject missing/malformed references without falling back to delivery IDs, and preserve ordinary resource list selection.
Add 16 focused regressions for Inbox/Outbox, frozen mappings, malformed references, access denial/retry, and ordinary lists; add two real PostgreSQL/signed-HTTP mailbox flows guarded by full-row/read-only evidence.
Validation: against original source the focused suite gives 15 failed / 1 passed; after the fix 16 pass. All 72 non-PostgreSQL TUI checks pass, full Ruff check/format (589 files), Python 3.15 compilation, wheel/sdist build and package-content verification pass locally with locked dependencies. Four PostgreSQL TUI tests were deselected locally because initdb is unavailable; CI must run them and the full contract/deployment gates before merge. No production deployment or protocol/write behavior change.