Repository navigation
Enforce the global storage quota for encrypted keystores - #130
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
keystore_entriesbut omitted those bytes from the service-widemax_storage_bytesaccounting, allowing many attacker-created identities to consume unbounded storage.Description
SUM(length(ciphertext))fromkeystore_entriesto_storage_bytes()and to the reportedstats()payload askeystore_bytes.cfg.max_storage_bytesby computing the previous entry size and checkingself._storage_bytes() - previous + new > cfg.max_storage_bytes, returning HTTP 507 on overflow while preserving the per-identity limits and allowing size-reducing replacements.keystore_bytesand totalbytesin stats; update the test harness accordingly (tests/test_topics_profiles.py).max_storage_bytescapacity (src/msgd/config.py,src/msgd/render.py,README.md).Testing
uv run ruff format --check .anduv run ruff check ., which passed.uv run python -m unittest tests.test_topics_profiles.TopicsProfilesCase.test_profile_keystore_stores_only_sealed_ciphertext -v, which passed.uv run python -m unittest discover -s tests -v, yielding all tests passing (145 passed, 1 skipped due to optionalVALKEY_TEST_URLconfiguration).max_storage_bytesand verified accounting after a successful write.Codex Task