Repository navigation
Limit achievement.start persistent writes and honor write pause - #127
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
achievement.startthat could be exploited by temporary-token holders to exhaust database storage.achievement.startrespects the global emergencyaccept_writespause so capacity-sensitive behavior is consistent with other writes.Description
src/msg/plugins/achievements.pytheachievement.starthandler now rejects requests when the subject already has the grant (achievement_already_granted) or an unexpired active ceremony (achievement_ceremony_active), deletes stale ceremony rows for the subject, and then allocates a single new ceremony row.src/msg/core/executor.pytheachievement.startoperation was added to thecapacity_writesset so it is blocked whenruntime_config.accept_writesisFalse.tests/test_achievements.pyto cover duplicate-start rejection, expired-ceremony replacement, and honoring the capacity pause forachievement.start.Testing
uv run --no-project --python /root/.pyenv/versions/3.14.4/bin/python -m compileall -q src/msg tests/test_achievements.py, which succeeded.uv run --no-project --python /root/.pyenv/versions/3.14.4/bin/python --with 'ruff>=0.14' ruff check src/msg/plugins/achievements.py tests/test_achievements.py, which succeeded.git diff --checkto validate whitespace and formatting changes, which reported no issues.pytestsuite viauv run ... pytest -q tests/test_achievements.pybut test execution was blocked during fixture setup because the environment is missing PostgreSQL tooling (initdb), so the integration tests could not complete in this environment.Codex Task