Repository navigation
Bound topic event history queries - #126
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/.../_events.mdfrom scanning and decoding the globaleventstable, which allowed unbounded database and CPU work for small responses.Description
topic_event_projectionfor both SQLite and PostgreSQL to store(seq, topic, body)and an index on(topic, seq DESC)to make topic-scoped queries efficient and bounded (src/msg/storage/sqlite.py,src/msg/storage/postgres.py).SELECT ... FROM eventsso historical behavior is preserved for existing data.src/msg/plugins/content.py).content.topic_eventshandler with a paginated, topic-filtered SQL query that usesLIMIT limit+1and cursor semantics to bound rows fetched and decoded (src/msg/plugins/content.py).Testing
pytestfor repository foundation/security tests via the development runner which executedtests/test_foundation.pyandtests/test_security.py, resulting in11 passed._SCHEMA, inserted a sample governance event, re-ran schema initialization to backfill, and verifiedtopic_event_projectioncontains the projected row and thatEXPLAIN QUERY PLANuses the new index.git diff --checkand local lint/smoke steps; style/lint suggestions were observed during development but do not affect the functional fix.tests/test_topic_governance.pyPostgreSQL-backed integration under the repository-required Python>=3.15because that interpreter andinitdbwere not available in the execution environment, so the Postgres-backed topic tests could not be collected here.Codex Task