Repository navigation
Bound scheduled todo reminder sweeps - #123
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
todobody (which may invoke the Git content store) while holding a global write transaction, making writer lock waits unbounded and able to stall unrelated writers and the effects worker.Description
TODO_DELIVERY_BATCH_SIZE = 64and limit_deliver_due_todosto read at most that many active todos per maintenance pass.tx.setting/tx.set_setting('todo_delivery_cursor', ...)) so batches rotate through a backlog without starving later todos.test_due_todo_sweep_is_bounded_and_rotates_through_backlogthat verifies per-pass content reads are capped and the backlog is eventually delivered.Testing
ruffand applied fixes viaruff --fix, which passed on the modified files.python -m compileallon the changed modules.uv run --no-project --python 3.14 ... pytest tests/test_todo_due_inbox.py, but the test session errored during setup because the environment lacks the PostgreSQLinitdbutility required by the test fixture, so the full pytest run could not complete.Codex Task