Skip to content

fix: revalidate compact cache projections across six real read clients - #115

Merged
LIghtJUNction merged 1 commit into
mainfrom
codex/c-read-integrity-20260928
Sep 28, 2026
Merged

LIghtJUNction merged 1 commit into
mainfrom
codex/c-read-integrity-20260928

Conversation

@LIghtJUNction

Copy link
Copy Markdown
Contributor

Scope

Refs #76, #78, #82, #83. Narrow C increment; do not close the umbrella acceptance issues.

Fix discovery.get's default compact projection validator mismatch. Full and compact representations are matched exactly only after current authorization and projection; array nulls, fields and persisted Revision/signature bytes are not normalized. A stale digest cannot authorize a read.

Evidence

Base 67401759a853c69fc5cb234982e1f7020b650542; feature head 3e2763106e7755a60f6836476a16279e37ca5c78; expected reviewed tree d6e03d603b1135d704c97b8434edb13c7454602e.

Local Python 3.13.5 unit reproduction: 4 failed/8 passed before, 12 passed after. Combined Python 3.15.0rc2 / real PostgreSQL 17.11 / Valkey 8.1.1: 18 passed, 0 failed, 0 skipped, 87.27s. Six actual HTTP/PathGET/GraphQL/MCP HTTP/CLI subprocess/MCP stdio clients exercise default current, historical, meta and history projections before and after direct-grant revocation. Tests compare complete business rows and exact content-file hashes, and forbid content mutation, job notification, SMTP/Webhook/sandbox invocation on reads.

The final-head Python 3.15/PostgreSQL16/Valkey9 four core shards, exact JUnit node-ID gate, conformance and wheel/sdist are not yet verified. This PR is not ready to merge until that run and refreshed base/head/diff/reviews are checked. No skips, xfails, allowlists, larger timeouts or production bypasses.

Only four product files change. Auxiliary offline-toolchain and patch transport workflows are not included. No production deployment, Root/PIN/secrets/funds/recovery/deletion or real outbound sends. #112/#103 remain owned by A/B; refresh their actual merged/head status rather than repeat their work. Remaining C scope is indexed in docs/C_READ_ACCEPTANCE.md.

Copilot AI lite review requested due to automatic review settings September 28, 2026 08:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-28T08:41:36.367865Z 3e27631 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

串行集成核验完成:已读全部4文件diff、评论及review threads(0未解决)。精确head 3e2763106e7755a60f6836476a16279e37ca5c78 的 Rewrite contracts 36398381209 completed/success;下载全部4份产物并逐一核对GitHub提供的SHA-256,独立比较每分片JUnit真实node ID与manifest selected/all,1342 core(326/353/355/308)+8 conformance,0失败/错误/跳过、0缺失/重复;wheel/sdist均在shard0。已检查产物中的discovery.get上下文:缓存匹配仍在当前鉴权与字段投影之后,未修改持久Revision/签名字节。Copilot因配额未完成不视为批准,Codex安全review完成且无线程。

本次仅Refs #76/#78/#82/#83,不关闭总体验收。将使用固定head合并并读取main实际tree;后续#112/#103需保留本修复。无生产部署/资金/真实外发。

@LIghtJUNction
LIghtJUNction merged commit eb67b5a into main Sep 28, 2026
5 checks passed
LIghtJUNction added a commit that referenced this pull request Sep 28, 2026
…rization

Preserve #112/#116 recovery history and merged #115/#117 guards. Exact combined tree 1a8a28f passed CI36404029543 and Recovery safety36404029733: 1544 core + 8 conformance, four SHA-verified artifacts with exact disjoint JUnit node IDs, zero failures/errors/skips, wheel/sdist. Both integration-test failures fixed without changing quarantine or OS-admin/console gates. Reviewed exact head. Refs #64, #65, #68, #69, #70, #81, #83, #84, #85. Full policy promotion and production field evidence remain incomplete; no production actions.
@github-actions
github-actions Bot deleted the codex/c-read-integrity-20260928 branch September 28, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants