Repository navigation
ci: fix nested fixture collection and require complete sharded evidence - #104
Merged
Merged
Conversation
Refs #83 and #85. Remove redundant fixture imports that conflict with nested conftests. Partition every collected pytest node across four isolated runners; preserve the contracts gate, all tests, conformance, tokenizer and build. Reject missing, duplicate, inconsistent or failed evidence. Install git-lfs for the real-client regression.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LIghtJUNction
added a commit
that referenced
this pull request
Sep 27, 2026
Refs #71, #72, #73, #104. Preserve current main and all market changes; reuse the six reviewed CI-only blobs from ae64f40. Remove the conftest alias collision and require all four disjoint test partitions, conformance and build. No application semantics or production effects change in this integration.
This was referenced Sep 27, 2026
github-actions
Bot
deleted the
fix/issues-83-85-complete-ci-evidence
branch
September 28, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #83 and #85. This fixes two concrete integration/verification blockers; it is not full chapter-15 acceptance.
Collection regression
After parallel #101 introduced nested conftests,
from conftest import installedin test_service (and its re-export in test_transfer) could resolve to the wrong module. Pytest already discovers the fixture. Remove those redundant imports without changing fixture behavior. A fresh-process regression failed before and passed after; combined source collection now succeeds instead of exiting before executing tests.Keep every test while bounding CI duration
The previous single 20-minute job cancelled #95/#97/#98 before complete verification. Run four disjoint partitions of all collected node IDs, including nested and parametrized/new tests. Do not maintain a test allowlist, drop tests, mark failures xfail or increase the timeout. Each isolated runner retains real PostgreSQL 16/Valkey/Python 3.15. Install git-lfs so its real-client check executes.
The existing
contractsgate now verifies all four manifests and JUnit reports: identical complete collection, correct shard identity, no duplicates/omissions, exact executed-test counts, no errors/failures, and every runner successful. Conformance with the real tokenizer and installable builds remain mandatory in shard 0. Artifacts are uniquely namedrewrite-verification-0through-3and merged only for evidence validation.Tests
18 local tests passed for the fresh collection regression and partition/gate checks. Gate negatives include missing manifests/reports, duplicate shard IDs, missing test results, changed collection, errors and failures. Standard unsharded pytest remains unchanged. A combined local integration run is separate and must not be mistaken for the complete Python 3.15 CI gate.
No application schema, CA, authorization, production configuration or deployment change. The independently reviewed #95–#98 changes are not included in this CI-only PR.