Fix rotation animation error on iOS 26 - #636
Merged
Merged
Conversation
TimOliver
added a commit
that referenced
this pull request
Jul 26, 2026
Bumps both podspecs and the framework MARKETING_VERSIONs, and gives the changelog a proper 3.1.2 section (the two PR #636 fixes were previously misfiled under the already-released 3.1.1 heading).
pull Bot
pushed a commit
to jasonkneen/TOCropViewController
that referenced
this pull request
Jul 28, 2026
3.1.2 was already tagged and pushed to CocoaPods trunk on 2026-04-07, so this work needed a new version number. It's a minor rather than a patch bump because the release changes public API: TOCropView.gridOverlayView, and TOCropToolbar's doneTextButton and cancelTextButton, are now annotated nullable, which is source-breaking for Swift callers that access them directly. Bumps both podspecs and all four MARKETING_VERSIONs, dates the accumulated release notes, and links each entry to the pull request it came from (TimOliver#648 through TimOliver#651; the build fix went to main directly and has no PR). Also moves the TimOliver#636 fix up out of the 3.1.1 section, where it had been filed after that release went out, and splits it into the two distinct fixes it actually made. main's 3.1.2 heading gains the underline every other heading in the file has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the crop box would be misaligned as it was rotating. This was happening because we now rely on the toolbar's position as part of the visible inset calculation, so this now needs to happen before laying out the crop box.