Skip to content

Expose the reviewed source-bound directed graph API - #68

Draft
ThorFuchs wants to merge 3 commits into
mainfrom
feature/json-inspection-graph-public-v1
Draft

ThorFuchs wants to merge 3 commits into
mainfrom
feature/json-inspection-graph-public-v1

Conversation

@ThorFuchs

@ThorFuchs ThorFuchs commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Change

Expose the owner-reviewed 34-declaration directed/simple graph API inside existing JSONInspection. An explicit immutable profile selects disjoint node/edge arrays and exact string fields; checked construction validates the entire graph before publishing source-attached metadata, values/spans and bounded source-order BFS. Queries explicitly re-admit the complete captured source under independent finite budgets.

Private CSR buffers, node ID staging, edge records, reducers, context and meter remain inaccessible. No product, dependency, JSON identity, mutation or serializer is added. Missing/null/wrong-kind and typed core operational failures stay distinct; quotas/cancellation never return a successful partial graph/component.

Source and sibling order

Based directly on main 1a0306d076a08c8c43281f91412a11cd744ff3f6; exact qualified donor tree b832f6554a0277ac1776ad84d81ba3296d2048f8 from draft #67 / 81485930f859131d0802691ca6370f482ba62911 was replayed first in a separate provenance commit. PR #67 remains unchanged as evidence. Independent set/matrix #66 remains draft at d566f283f5826cb85fbcbe132e06a179b9589822; its twelve shared metadata/context files require additive reconciliation and fresh combined qualification if it merges first. No sibling work is imported.

Qualification

Retains G01–G32, all 27 pinned fixtures, original reducer 2+/20- and graph helper 2+/8- codegen. Adds GP01–GP16, Debug/Release/ASan distinct-package consumer, three compiled DocC snippets and 26 external ordinary codegen rejections. Replaces only obsolete invisible-public-type negatives with private builder/query/stage rejections. Discovery requires 124 Inspection functions, 827 native/811 Linux/723 WASI, unchanged 325/288 parameter cases, all 49 core caps and 126 maintenance identities. Final head 68cbdf6183f05a01f283869b180d254aca190e30 is qualified: all eight Native/Linux jobs pass; full Node WASI 78 commands and 14 supplemental commands pass, as do the six strict Apple SDK commands, exact-revision Debug/Release/ASan consumer and actual DocC site checks (9 navigators, 1,826 routes, 9,119 links). Actual counts are 827 native / 811 Linux / 723 WASI, with 325/288 parameter invocations and 53/52 targeted sharing functions. A fresh base-plus-patch reconstruction reproduces the actual source archive byte-for-byte: SHA-256 d7caa6509560a6897409f52148339fe9ea72f718b7011f1bb4ed4e4b73406c6a, 1,991,833 bytes, 1,315 source files. An initial SDK evidence-write ENOSPC failure was preserved and all six unchanged-source SDK commands rerun successfully; cancelled predecessor CI and review-tool setup failures remain in the local return. No failure is relabeled a pass.

Review boundary

Owner approved the exact compiler-derived draft signature surface subject to qualification. This PR stays draft. No merge, ready transition, release or tag is authorized. Controlled G4 remains HOLD, with no timing, speed or RSS claim. Whole-source query costs and potentially quadratic exact build scans are explicit.

Final review

Promotion retains the approved 34 additions: total 1,206 authored declarations, no old declaration changes, Navigation56/Inspection129. Source review restored explicit package access on private edge-record members; the effective public API and graph algorithms are unchanged. One symbol-graph rendering difference (Self versus its final struct) is recorded with exact USR/source/typed-consumer proof. This draft remains unmerged and not ready; source/main/protection must be refreshed before any future separately authorized integration.

Exact source tree b832f65 from private donor PR #67 (8148593), replayed directly on current main. Public promotion remains gated by owner signature review; no NAV10 dependency or merge authorization.
Promote exactly the owner-approved 34 declarations inside JSONInspection; retain private CSR/reducers and original single-meter semantics. Add sixteen public cases, separate-package consumer, three executable DocC examples and strict 26-negative compiler receipts. Preserve G01–G32, pinned fixtures, original ownership matrices, 49 core caps and 126 maintenance identities. No new product, merge, release or performance claim.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant