Repository navigation
fix(review): stabilize highlights, links, and image comments - #252
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying markdownviewer with
|
| Latest commit: |
86f3455
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://12b39791.markdownviewer.pages.dev |
| Branch Preview URL: | https://fix-review-comment-highlight.markdownviewer.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The highlight segmenter used the number of split boundaries to decide whether a text node needed work. A whole-node selection has only its existing start and end boundaries, so it was incorrectly treated as non-intersecting and skipped. This affected fully selected inline nodes and could leave gaps in selections spanning multiple formatted nodes.
Preview links were also handled independently after Review Mode click handling. That allowed hyperlinks and linked badges to open or scroll even during comment selection.
Finally, legacy block-side action styles still reserved 76 px after a commented image even though Comments v2 no longer renders those actions. A 100 px image therefore expanded to a 176 px box and its visible content shifted 38 px off center.
Testing
npm run check:static