Skip to content

fix(review): stabilize highlights, links, and image comments - #252

Merged
ThisIs-Developer merged 3 commits into
mainfrom
fix/review-comment-highlight-mapping
Aug 28, 2026
Merged

ThisIs-Developer merged 3 commits into
mainfrom
fix/review-comment-highlight-mapping

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Aug 28, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Treat every rendered text node intersecting a saved review range as highlightable, including selections that cover the entire node.
  • Preserve continuous persistent highlights across bold, italic, link, inline-code, and strikethrough boundaries.
  • Suppress external links, internal anchors, linked badges, and auxiliary-click navigation while Comments mode is active.
  • Keep linked images selectable as comment targets and restore normal link behavior after Comments mode closes.
  • Remove obsolete legacy review gutters so image, table, diagram, heading, and paragraph geometry remains unchanged during selection and after comments are added.
  • Regenerate the desktop application script and style mirrors.
  • Add regressions for the README highlighting structure, submit/re-render/reload persistence, Comments-mode link handling, and before/after image geometry.

Why

The highlight segmenter used the number of split boundaries to decide whether a text node needed work. A whole-node selection has only its existing start and end boundaries, so it was incorrectly treated as non-intersecting and skipped. This affected fully selected inline nodes and could leave gaps in selections spanning multiple formatted nodes.

Preview links were also handled independently after Review Mode click handling. That allowed hyperlinks and linked badges to open or scroll even during comment selection.

Finally, legacy block-side action styles still reserved 76 px after a commented image even though Comments v2 no longer renders those actions. A 100 px image therefore expanded to a 176 px box and its visible content shifted 38 px off center.

Testing

  • npm run check:static
  • Focused Review Mode suites: 15 passed in Chromium
  • Whole-node/cross-format regression: passed in Chromium, Firefox, and WebKit
  • Link and linked-badge regression: passed in Chromium, Firefox, and WebKit
  • Image geometry regression (selection, composer, submit, reload): passed in Chromium, Firefox, and WebKit
  • Full Chromium suite: 168 passed; one unrelated timing-sensitive encrypted-journal test timed out under the full parallel run and passed independently on retry (1 passed)

@vercel

vercel Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview Aug 28, 2026 8:24pm

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86f3455
Status: ✅  Deploy successful!
Preview URL: https://12b39791.markdownviewer.pages.dev
Branch Preview URL: https://fix-review-comment-highlight.markdownviewer.pages.dev

View logs

@ThisIs-Developer ThisIs-Developer changed the title fix(review): preserve whole-node comment highlights fix(review): preserve highlights and disable preview links Aug 28, 2026
@ThisIs-Developer ThisIs-Developer changed the title fix(review): preserve highlights and disable preview links fix(review): stabilize highlights, links, and image comments Aug 28, 2026
@ThisIs-Developer
ThisIs-Developer merged commit f2aba63 into main Aug 28, 2026
5 checks passed
@ThisIs-Developer
ThisIs-Developer deleted the fix/review-comment-highlight-mapping branch August 28, 2026 20:28
@ThisIs-Developer ThisIs-Developer added bug Something is broken or not working as expected. ui/ux User interface, layout, interaction, usability, or visual improvements. labels Oct 2, 2026 — with ChatGPT Codex Connector

This branch was successfully deployed

1 active deployment
Preview — 86f34555 Deployed Aug 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken or not working as expected. ui/ux User interface, layout, interaction, usability, or visual improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant