Skip to content

feat(editor): add quick table selector - #250

Merged
ThisIs-Developer merged 10 commits into
mainfrom
feat/issue-246-quick-table-selector
Aug 28, 2026
Merged

ThisIs-Developer merged 10 commits into
mainfrom
feat/issue-246-quick-table-selector

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Aug 27, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Replace the table toolbar action with an accessible 8×8 quick selector that supports hover, click, and arrow-key navigation.
  • Preserve the original compact cell dimensions.
  • Show the dimension highlight only while the pointer is over the grid; clear it when the pointer leaves. Keyboard focus retains an accessible preview.
  • Treat the selected row count as the total rendered rows, including the header row.
  • Keep a Custom table dialog for dimensions up to 20×20 and clarify its row-count behavior.
  • Sync the browser changes into the desktop resources and add regression coverage.

Why

Issue #246 showed that excluding the header from the row count made the table controls feel reversed. The 8×8 picker makes common dimensions quick to select, while the Custom table dialog remains available for anything larger.

How it was tested

  • npm test — 162 Chromium end-to-end tests passed for the completed table-selector implementation.
  • Focused table-picker tests cover the 64-cell boundary, hover-only preview, keyboard navigation, cell dimensions, custom-table fallback, and icon rendering.
  • npm run check:static — browser and desktop resource checks passed.
  • node assets/i18n/audit-ui-locales.mjs — 15 locale catalogs passed.

Documentation

The updated labels and helper text document the behavior in the UI; no separate documentation changes are required.

Closes #246

@vercel

vercel Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview Aug 28, 2026 9:02am

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: e914474
Status: ✅  Deploy successful!
Preview URL: https://a39b767a.markdownviewer.pages.dev
Branch Preview URL: https://feat-issue-246-quick-table-s.markdownviewer.pages.dev

View logs

@ThisIs-Developer
ThisIs-Developer merged commit 91ca1f7 into main Aug 28, 2026
5 checks passed
@ThisIs-Developer
ThisIs-Developer deleted the feat/issue-246-quick-table-selector branch August 28, 2026 09:13
@ThisIs-Developer ThisIs-Developer added enhancement New feature, improvement, or usability enhancement. ui/ux User interface, layout, interaction, usability, or visual improvements. labels Oct 2, 2026 — with ChatGPT Codex Connector

This branch was successfully deployed

1 active deployment
Preview — e9144741 Deployed Aug 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, improvement, or usability enhancement. ui/ux User interface, layout, interaction, usability, or visual improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Confusion on creating a table

1 participant