Skip to content

feat(ui): consolidate toolbar and add selection-first comments - #242

Merged
ThisIs-Developer merged 36 commits into
mainfrom
agent/consolidate-icon-toolbar
Aug 23, 2026
Merged

ThisIs-Developer merged 36 commits into
mainfrom
agent/consolidate-icon-toolbar

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Aug 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

This PR modernizes two connected parts of the editor UI:

  • consolidates document and header actions into a clearer icon-first toolbar;
  • refreshes theme and private-workspace switches, settings surfaces, dropdown motion, and Release Notes action states;
  • replaces the previous comments/suggestions experience with a compact, selection-first Review Mode.

Review Mode

  • Select rendered text or supported rich content, choose New, and submit feedback without changing Markdown source.
  • Keeps a pending text range visibly selected while automatically placing the real keyboard focus and caret in the comment field.
  • Creates durable, visible text highlights after submission; highlights remain visible after reload.
  • Supports images, diagrams, rendered math, media, and YAML frontmatter tables as element targets. Code blocks remain excluded.
  • Treats YAML cell text as text selection, so a drag selection does not accidentally select or outline the entire table.
  • Adds compact review threads with author, timestamp, resolve/reopen, edit, delete, filtering, document/panel synchronization, and long-reply collapse/expand controls.
  • Adds nested replies with inline edit, delete, persistence, and positioned actions.
  • Uses toolbar-style thread borders at rest; open/hover states change the border to blue only, with no background flash.
  • Adds blinking start/end selection markers sized to the highlighted line box.
  • Closes an untouched composer and clears its pending selection when the user clicks away; typed drafts remain open.

Why

The previous comments interface was visually dense and mixed review metadata with the document workflow. The new flow keeps feedback anchored to rendered content, makes the next action obvious, and preserves a compact, consistent application UI across desktop and mobile layouts.

Data and compatibility

  • Review threads stay outside Markdown content and document exports.
  • Existing per-document review storage, Live Share review synchronization, workspace backup/restore, and Secret Workspace behavior continue to use the established review collection.
  • Generated desktop resources are refreshed alongside the web assets.

Verification

  • npm run check:static
  • Comments redesign Playwright suite: 7/7 passed
  • Review Mode and review design Playwright suites: 5/5 passed
  • Nested reply edit/delete/persistence stress repeat: 3/3 passed

Documentation

No separate documentation change was required for these focused UI and interaction updates; the behavior is covered by the PR description and automated regression tests.

@vercel

vercel Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview Aug 23, 2026 6:49pm

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d070bd
Status: ✅  Deploy successful!
Preview URL: https://b2a5ff5b.markdownviewer.pages.dev
Branch Preview URL: https://agent-consolidate-icon-toolb.markdownviewer.pages.dev

View logs

@ThisIs-Developer ThisIs-Developer changed the title feat(review): add compact Review Mode feat(ui): consolidate toolbar and add selection-first comments Aug 23, 2026
@ThisIs-Developer
ThisIs-Developer force-pushed the agent/consolidate-icon-toolbar branch from d343e0f to 0832729 Compare August 23, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ThisIs-Developer
ThisIs-Developer merged commit c391594 into main Aug 23, 2026
6 checks passed
@ThisIs-Developer
ThisIs-Developer deleted the agent/consolidate-icon-toolbar branch August 23, 2026 19:04
@ThisIs-Developer ThisIs-Developer added enhancement New feature, improvement, or usability enhancement. ui/ux User interface, layout, interaction, usability, or visual improvements. labels Oct 2, 2026 — with ChatGPT Codex Connector

This branch was successfully deployed

1 active (outdated) deployment
Preview — 0342a432 Deployed Aug 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, improvement, or usability enhancement. ui/ux User interface, layout, interaction, usability, or visual improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants